Skip to content

Conversation

@wilfonba
Copy link
Collaborator

@wilfonba wilfonba commented May 21, 2025

Description

Updates Frontier modules for CCE 19.0.X and the profiling updates.

Type of change

Please delete options that are not relevant.

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Ran
./mfc.sh run examples/3D_performance_test/case.py -c frontier -n 1
./mfc.sh run examples/3D_performance_test/case.py -c frontier -# PERF_Test -n 1 --rcu
./mfc.sh run examples/3D_performance_test/case.py -c frontier --rsys
and all worked as expected.

@wilfonba wilfonba marked this pull request as ready for review May 21, 2025 21:27
@wilfonba wilfonba requested review from a team and sbryngelson as code owners May 21, 2025 21:27
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.24%. Comparing base (4949c07) to head (1d2c7ca).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   43.34%   43.24%   -0.11%     
==========================================
  Files          68       68              
  Lines       20128    20182      +54     
  Branches     2400     2401       +1     
==========================================
+ Hits         8725     8728       +3     
- Misses       9934     9985      +51     
  Partials     1469     1469              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson
Copy link
Member

@wilfonba did you test that the CPU case works?

If so, can you add it as a CI run? So each CI test run will run the CPU version and the GPU version.

I'm realizing I'm ballooning your PR here, apologies. I've been wanting to do this for a while, actually.

@wilfonba
Copy link
Collaborator Author

@sbryngelson Yeah, I can. No worries, shouldn't take long at all

@sbryngelson sbryngelson self-requested a review May 23, 2025 18:14
@wilfonba
Copy link
Collaborator Author

@sbryngelson I'll send a message when this is ready to merge. I was looking at the Frontier logs and noticed that both the CPU and GPU runners ran the CPU code due to an error I made in the workflow files, so I did what I think corrected that, but I'll have to wait for the runners.

@sbryngelson
Copy link
Member

good find, thanks

@sbryngelson
Copy link
Member

this appears to be working, ?

@wilfonba
Copy link
Collaborator Author

@sbryngelson yep. Ready to merge now. I had to make a second change and let the runners go overnight.

@sbryngelson sbryngelson merged commit 8a24386 into MFlowCode:master May 24, 2025
28 of 29 checks passed
@wilfonba wilfonba deleted the FrontierModuleUpdate branch July 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants